Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement non-linear wait before drop(close) #1603

Merged
merged 8 commits into from
Nov 28, 2024
Merged

implement non-linear wait before drop(close) #1603

merged 8 commits into from
Nov 28, 2024

Conversation

yellowhatter
Copy link
Contributor

No description provided.

@yellowhatter yellowhatter self-assigned this Nov 21, 2024
@github-actions GitHub Actions
Copy link

PR missing one of the required labels: {'internal', 'new feature', 'documentation', 'dependencies', 'bug', 'breaking-change', 'enhancement'}

@yellowhatter yellowhatter added enhancement Existing things could work better release Part of the next release and removed release Part of the next release labels Nov 21, 2024
@yellowhatter yellowhatter marked this pull request as ready for review November 22, 2024 11:13
@yellowhatter yellowhatter requested a review from Mallets November 22, 2024 11:13
@yellowhatter
Copy link
Contributor Author

On my HW this doesn't make any visible performance change.

@yellowhatter yellowhatter changed the title implement non-linear wait before drop implement non-linear wait before drop(close) Nov 22, 2024
@yellowhatter yellowhatter added the release Part of the next release label Nov 27, 2024
Mallets
Mallets reviewed Nov 27, 2024
View reviewed changes
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Nov 27, 2024
View reviewed changes
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Nov 27, 2024
View reviewed changes
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
@yellowhatter
Copy link
Contributor Author

The perf is ok:
2024:11:27-16:48:25 throughput aggregated

@gabrik
Copy link
Contributor

gabrik commented Nov 27, 2024

@RemiBarthe 👀

@yellowhatter
Copy link
Contributor Author

Updated with old functionality for Block.
The perf is good:
2024:11:28-11:09:01 throughput aggregated

@Mallets Mallets merged commit 7e044ad into eclipse-zenoh:main Nov 28, 2024
13 checks passed
@Mallets Mallets mentioned this pull request Nov 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees

@yellowhatter yellowhatter

Labels
enhancement Existing things could work better release Part of the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yellowhatter @gabrik @Mallets